Conversation
…5.12.09.17.39.06 Other tools: - conda-build 25.11.0 - rattler-build 0.53.0 - rattler-build-conda-compat 1.4.10
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20076484113. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Adding |
recipe/annexremote_linux.patch
Outdated
| "tqdm>=4.32.0", | ||
| "typing_extensions>=4.0.0; python_version < '3.11'", | ||
| - "annexremote", | ||
| + "annexremote; platform_system=='Linux'", |
There was a problem hiding this comment.
AFAIK annexremote is not OS specific per se and definitely works on OSX... having said that I now notice we do not test it in its unittests anywhere else but linux. But we do test datalad across OSes, and we do not limit annexremote only to linux.
There was a problem hiding this comment.
While it doesn't look like, pip-check did complain about it on Windows and macos. Let me revert this patch so we can see this other error. Hold on.
There was a problem hiding this comment.
Both Windows and macos are failing with:
+ pip check
annexremote 1.2.1 is not supported on this platform
WARNING: Tests failed for datalad-1.2.3-pyh707e725_0.conda - moving package to /Users/runner/miniforge3/conda-bld/broken
There was a problem hiding this comment.
we should address this in
|
@conda-forge-admin, please rerender |
| - tqdm >=4.32.0 | ||
| # NB: remove typing-extensions when droppping py310! | ||
| - typing-extensions >=4.0.0 | ||
| - annexremote |
There was a problem hiding this comment.
please keep overall list sorted thus avoiding such huge hard to review diff
|
Lots of good stuff in the fixes to the recipe -- I would hate to redo those ;) have juice left to bring it closer to finishing line ? I wonder if we could minimize diff to what matters and should be fixed here and not in e.g. annexremote |
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the |
|
Thank you for all your work on this one... I did proceed forward with extended list of dependencies in and also fixed up annexrepo (I think) so overall we are good but IIRC you had more changes to recipe happen you would like to contribute |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)